Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused functions from testkomodo #6120

Closed
wants to merge 1 commit into from
Closed

Remove unused functions from testkomodo #6120

wants to merge 1 commit into from

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Sep 20, 2023

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@dafeda dafeda self-assigned this Sep 20, 2023
@dafeda dafeda requested a review from berland September 20, 2023 10:15
@dafeda dafeda added the release-notes:skip If there should be no mention of this in release notes label Sep 20, 2023
@berland
Copy link
Contributor

berland commented Sep 20, 2023

This function is called (eventually) from here: https://github.com/equinor/komodo-releases/blob/453132c49cd777ed6218999e8932b33e6aa876ed/.github/workflows/run_tests_one_project.yml#L134C11-L134C20

@dafeda
Copy link
Contributor Author

dafeda commented Sep 20, 2023

Thanks 🤯

@dafeda dafeda closed this Sep 20, 2023
@dafeda dafeda deleted the clean_testkomodo branch September 20, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berland berland Awaiting requested review from berland

Assignees

@dafeda dafeda

Labels
release-notes:skip If there should be no mention of this in release notes
Projects
SCOUT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dafeda @berland